]> dgit.raspbian.org Git - gnome-shell.git/commit
screenshot: Unrestrict PickColor
authorFlorian Müllner <fmuellner@gnome.org>
Sat, 25 Sep 2021 12:15:32 +0000 (14:15 +0200)
committerMarge Bot <marge-bot@gnome.org>
Wed, 6 Oct 2021 17:34:18 +0000 (17:34 +0000)
commita3dcdaae30bdcbadec7ba3fa31c9eb0bb2a4c8c2
treecd3af10b4be663d068873d2e32177cfb826bc218
parent82e16a206f2a98ffdaf38f535531dc117f62e473
screenshot: Unrestrict PickColor

Commit dd2cd6286cd3 restricted callers of the screenshot methods to
portal implementations, gnome-settings-daemon and gnome-screenshot.

That restriction does make sense for the actual screenshot methods,
but `PickColor` is actually used by GTK in its color picker (and
therefore may be called from arbitrary applications).

Fix this by unrestricting access to `PickColor` again. Considering that
the method is always interactive, it's not very privacy/security-sensitive
anyway.

https://gitlab.gnome.org/GNOME/gtk/-/issues/4283

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1990>
js/ui/screenshot.js